-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event handler to Applier/Destroyer #1199
Conversation
ac9518a
to
7c70ff3
Compare
9d0406a
to
54f990a
Compare
54f990a
to
0a9a967
Compare
/retest |
0a9a967
to
0d2c829
Compare
c168435
to
5c19187
Compare
Use an injected event handler function to avoid needing to cache errors in the supervisor. Instead, cache errors in the Updater, which already has a lock for this. This event handler simplifies the Applier/Destroyer API and makes it easy to add more events in the future, like for inventory updates.
5c19187
to
ac48b42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use an injected event handler function to avoid needing to cache errors in the supervisor. Instead, cache errors in the Updater, which already has a lock for this.
This event handler simplifies the Applier/Destroyer API and makes it easy to add more events in the future, like for inventory updates.
Dependencies: