Add event handler to Applier/Destroyer #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlkfi
force-pushed
the
karl-applier-events
branch
from
ac9518a
to
7c70ff3
Compare
karlkfi
force-pushed
the
karl-applier-events
branch
from
9d0406a
to
54f990a
Compare
nan-yu
reviewed
May 1, 2024
karlkfi
force-pushed
the
karl-applier-events
branch
from
54f990a
to
0a9a967
Compare
|
/retest |
karlkfi
force-pushed
the
karl-applier-events
branch
from
0a9a967
to
0d2c829
Compare
karlkfi
force-pushed
the
karl-applier-events
branch
2 times, most recently
from
c168435
to
5c19187
Compare
karlkfi
changed the title
Use an injected event handler function to avoid needing to cache errors in the supervisor. Instead, cache errors in the Updater, which already has a lock for this. This event handler simplifies the Applier/Destroyer API and makes it easy to add more events in the future, like for inventory updates.
karlkfi
force-pushed
the
karl-applier-events
branch
from
5c19187
to
ac48b42
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an injected event handler function to avoid needing to cache errors in the supervisor. Instead, cache errors in the Updater, which already has a lock for this.
This event handler simplifies the Applier/Destroyer API and makes it easy to add more events in the future, like for inventory updates.
Dependencies: